Skip to content

Add documentation about OpenXR render models #11014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

BastiaanOlij
Copy link
Contributor

Documentation in support of godotengine/godot#107388,
Probably needs some tweaking after this PR is merged.

@BastiaanOlij
Copy link
Contributor Author

Note: CI failures are related to upstream changes not being merged.

@AThousandShips AThousandShips added the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 11, 2025
@AThousandShips AThousandShips removed this from the 4.x milestone Jun 11, 2025
@skyace65 skyace65 removed the waiting on PR merge PR's that can't be merged until an engine PR is merged first label Jun 22, 2025
@skyace65 skyace65 added this to the 4.5 milestone Jun 22, 2025
@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 2ff45dc to 8b4ffc0 Compare June 23, 2025 07:36
@BastiaanOlij
Copy link
Contributor Author

Just rebased this, but need to update the image with the latest rename we did. One sec.

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 8b4ffc0 to ecae4f5 Compare June 23, 2025 08:31
@BastiaanOlij
Copy link
Contributor Author

Ok, image has been updated :)

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch 2 times, most recently from 42f4e50 to 1987c8d Compare June 24, 2025 01:11
@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 1987c8d to 8aac142 Compare June 24, 2025 05:16
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Should be good to merge once the demo project is merged.

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 8aac142 to 1b51729 Compare July 10, 2025 05:56
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines 90 to 92
This falls beyond the scope of this documentation but an example
implementation of this can be found in
`our hand tracking demo <https://github.com/godotengine/godot-demo-projects/tree/master/xr/openxr_render_models>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BastiaanOlij does the hand tracking demo as it is now do what's described in this note? I'm not seeing any updates for that demo project for render models.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn, I updated the URL but not the description, let me fix that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, changed this a little because the original didn't make sense anymore. So the link has moved to the next section as the demo is what was used to create the rest of the documentation.

@BastiaanOlij BastiaanOlij force-pushed the openxr_render_models_doc branch from 1b51729 to e3b1288 Compare July 14, 2025 01:50
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge once the demo project is merged (godotengine/godot-demo-projects#1218)

I've left a review comment on that

@skyace65 skyace65 merged commit 8febb9a into godotengine:master Jul 14, 2025
1 check passed
@skyace65
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:xr Related to XR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants